Add lsb-release dependency to agent and mgmt server on Debian/Ubuntu.#1412
Add lsb-release dependency to agent and mgmt server on Debian/Ubuntu.#1412ProjectMoon wants to merge 1 commit intoapache:4.6from greenqloud:pr-lsb-release
Conversation
|
LGTM, simple change |
|
Apparently the build of this pull request sucked Jenkins into a black hole. The build returns 404. |
|
I've updated this pull request @bhaisaab. The dependency needs to be added to cloudstack-agent as well due to a similar problem with the cloudstack-setup-agent script (they both depend on the same Python libraries). |
Needed because the cloudstack-setup-management and cloudstack-setup-agent scripts try to use the lsb_release command when detecting the OS. This is not always installed by default (e.g. on Debian 8).
ProjectMoon
changed the title
|
What do we do about this since it is against the 4.6 branch? Do you want to close this and open it against the 4.7 branch? |
|
Since it's a bug fix, according to the current CS workflow it should be put on the oldest supported release branch and then forward merged. I can resubmit it against 4.7 if need be though. |
|
@ProjectMoon Can you open a new PR against 4.7 with this? We're really only supporting 4.7.x onward. |
|
@ProjectMoon please close this and open against 4.7+, thanks tag:closeme |
|
Closing to open new PR. |
Add lsb-release dependency to mgmt server and agent on Debian/Ubuntu.New version of #1412, based on the 4.7 branch. * pr/1565: Add lsb-release dependency to mgmt server and agent on Debian/Ubuntu. Signed-off-by: Will Stevens <williamstevens@gmail.com>
4 participants
The cloudstack-setup-management script needs the lsb_release command. This command is provided by the
lsb-releasepackage on Debian and Ubuntu, and this is not always installed by default. So, it should be added as a dependency to cloudstack-management.